sijie commented on issue #1116: Cleanup registration client interface
URL: https://github.com/apache/bookkeeper/pull/1116#issuecomment-362693360
 
 
   @jiazhai since you did the interface abstraction, can you take a look to see 
if this work for you.
   
   @merlimat since pulsar is the main user of external zookeeper instance, can 
you review to make sure it is okay from your perspective.
   
   to be clear on this change, it would be ideal to remove that field 
completely. however since bookkeeper still supports passing external zookeeper 
client and most likely it won't be gone for any time soon, so I stick to just 
change it to `Optional<Object>` to remove zookeeper reference from metadata 
interfaces entirely. Let the implementation itself interpret this context 
object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to