sijie commented on a change in pull request #1137: Fix test regression due to
change in default ledger manager
URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167375931
##########
File path:
bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
##########
@@ -100,14 +108,7 @@ public void run() {
bk.close();
}
}
- for (int i = 0; i < 60; i++) {
- if (!t.isAlive()) {
- break;
- }
- Thread.sleep(100);
- }
-
- Assert.assertFalse("Thread should be finished", t.isAlive());
+ Assert.assertEquals(Integer.valueOf(0), f.get(30, TimeUnit.SECONDS));
Review comment:
can we get rid of timed wait here? we should just rely on the unit test
framework to timeout the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
