sijie commented on a change in pull request #1131: Split all versions images 
into released and latest
URL: https://github.com/apache/bookkeeper/pull/1131#discussion_r167386034
 
 

 ##########
 File path: tests/docker-all-versions-image/latest-image/pom.xml
 ##########
 @@ -0,0 +1,111 @@
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  <parent>
+    <groupId>org.apache.bookkeeper.tests</groupId>
+    <artifactId>all-versions-image</artifactId>
+    <version>4.7.0-SNAPSHOT</version>
+  </parent>
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.apache.bookkeeper.tests</groupId>
+  <artifactId>docker-latest-version-image</artifactId>
 
 Review comment:
   this seems to be a bit confusing to me. The name here sounds like an image 
include the latest version, which is actually not. This image is actually 
"all-versions-image". so I would suggest:
   
   - name the parent module as "test-docker-images"
   - name the module that builds the image of all released versions : 
"docker-all-released-versions-image"
   - name the module that builds the image of all versions : 
"docker-all-versions-image"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to