ivankelly commented on issue #1133: Integration smoke test
URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364902222
   > what are the issues blocking using it in tests.
   @sijie Nothing blocking persay, but I want the asyncClose issue revolved 
before I start using them. I think what you suggest before about changing the 
methods to have sync and async methods like pulsar is the best solution to 
this, but this would require changing all tests that use them after the change.
   Also, way we return CompletableFuture<> from everything is awkward to use in 
tests. You have to put .get() at the end of all calls, and can't directly catch 
specific exceptions. I'm aware I pushed for this at the time, having tried to 
use the apis a bit left me wiser.
   Anyhow, as I said to @eolivelli, I'm planning to come back to the API stuff, 
but I want the BC test stuff out of my head first.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to