sijie commented on issue #1132: Fix shutdown race which left ZK session open
URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364954818
 
 
   @ivankelly just fyi the lifecycle stuff wasn't designed for concurrent 
access. it assumes that only one thread is managing the lifecycle state. this 
PR changes the behavior of `beforeStart`, `beforeStop` and `beforeStop`, which 
was supposed to run before actual state changes. so I would suggest just adding 
synchronization to fix race condition, which doesn't change the original 
behavior and it is enough. because I don't think we need lifecycle management 
to have handle many concurrent accesses.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to