ivankelly commented on issue #1132: Fix shutdown race which left ZK session open
URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364958045
 
 
   If lifecycle changes are coming from multiple threads, it should be capable 
of concurrent access. Otherwise it's broken and should be removed. 
   
   The synchronized #close isn't a good fix. The removal of close() from main 
is better. I can strip the patch down to this to get things moving, and push 
the other changes separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to