kishorekasi commented on a change in pull request #1110: Issue 1109: Error out 
pending ops on TLS key mismatch exception
URL: https://github.com/apache/bookkeeper/pull/1110#discussion_r167674036
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -1014,9 +1032,7 @@ public void exceptionCaught(ChannelHandlerContext ctx, 
Throwable cause) throws E
         }
 
         if (cause instanceof IOException) {
-            // these are thrown when a bookie fails, logging them just pollutes
 
 Review comment:
   I introduced a WARN log, so removed the comment. I expect exceptions should 
be a rare event so we should not see them often in the logs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to