reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167771081
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommand.java ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.tools.cli.helpers; + +import java.util.Optional; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import lombok.Cleanup; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.client.api.BookKeeper; +import org.apache.bookkeeper.conf.ClientConfiguration; +import org.apache.bookkeeper.discover.RegistrationClient; +import org.apache.bookkeeper.stats.NullStatsLogger; +import org.apache.bookkeeper.util.ReflectionUtils; + +/** + * This is a mixin for commands that talks to discovery service. + */ +@Slf4j +public abstract class DiscoveryCommand extends ClientCommand { + + @Override + protected void run(ClientConfiguration conf) throws Exception { + Class<? extends RegistrationClient> regClientCls = conf.getRegistrationClientClass(); + @Cleanup("shutdown") ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(); + try (RegistrationClient regClient = ReflectionUtils.newInstance(regClientCls)) { + regClient.initialize( + conf, + executor, + NullStatsLogger.INSTANCE, + Optional.empty()); + run(regClient); + } + } + + @Override + protected void run(BookKeeper bk) throws Exception { + throw new UnsupportedOperationException("Discovery command only uses registration client"); Review comment: does this has to be UnsupportedOperation? shouldn't we use bk's regClient (bk.getRegClient()) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
