ivankelly commented on a change in pull request #1137: Fix test regression due 
to change in default ledger manager
URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167873701
 
 

 ##########
 File path: 
bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
 ##########
 @@ -38,6 +39,13 @@ public TestBenchmark() {
         super(5);
     }
 
+    @Before
+    public void setUp() throws Exception {
+        
baseConf.setLedgerManagerFactoryClassName("org.apache.bookkeeper.meta.FlatLedgerManagerFactory");
 
 Review comment:
   I'm well aware of suppressWarnings, but it was a small nit, that didn't add 
anything, the patch was already green with CI, was otherwise ready to go, just 
waiting on approvals and I wanted to get this change in asap, as master CI has 
been broken for 7 days now, and it's blocking other patches. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to