sijie commented on a change in pull request #1121: [Merge Yahoo repo]: 
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386840
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -787,6 +787,24 @@ public void onFailure(Throwable cause) {
         }
     }
 
+    /*
+     * Read the last entry in the ledger
+     *
+     * @param cb
+     *            object implementing read callback interface
+     * @param ctx
+     *            control object
+     */
+    public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
+        long lastEntryId = getLastAddConfirmed();
 
 Review comment:
   I think the implementation here is also a bit problematic. because 
`getLastAddConfirmed` is only reading the cached `lac`. this is okay for 
LedgerHandle. However this is not correct for ReadonlyLedgerHandle. 
   
   we should override this in ReadonlyLedgerHandle to use 
`asyncReadLastConfirmed` and in its callback to call 
`asyncReadEntriesInternal(...)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to