sijie commented on a change in pull request #1130: handle zookeeper session 
expire in zk ledger manager
URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r168329867
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
 ##########
 @@ -409,7 +426,7 @@ public void processResult(int rc, String path, Object ctx, 
byte[] data, Stat sta
     public void writeLedgerMetadata(final long ledgerId, final LedgerMetadata 
metadata,
                                     final GenericCallback<Void> cb) {
         Version v = metadata.getVersion();
-        if (Version.NEW == v || !(v instanceof LongVersion)) {
+        if (!(v instanceof LongVersion)) {
 
 Review comment:
   @eolivelli I mean v can not be `Version.New` because line 416 expects a 
LongVersion. also the ledger manager api have separate api for 
CreateLedgerMetadata and WriteLedgerMetadata. so we don't expect Version.New 
and Version.ANY on `WriteLedgerMetadata`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to