sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI 
URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351975
 
 

 ##########
 File path: bin/bookkeeper-cli
 ##########
 @@ -0,0 +1,153 @@
+#!/usr/bin/env bash
 
 Review comment:
   the thought here is eventually moving bin/ conf/ directories to the root 
module. since we will split bookkeeper-server into client and server module in 
future, and bookkeeper-dist is for packing the binary distribution. moving bin 
to top-level will make things easier and manageable. I am doing this for this 
new bookkeeper CLI first and will move other script after we split 
bookkeeper-server module in 4.8.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to