sijie commented on issue #1138: BP-31 BookKeeper Durability Anchor
URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365799993
 
 
   @eolivelli in general, I think we should use "Ignore CI" just before a 
committer is about to merge it, and it should be the committer who is merging 
the PR do this. otherwise, the comments will become unmanageable. For a BP 
change, it is probably okay. For other code changes, there might be other 
review comments and changes coming after you put "Ignore CI". Then the "Ignore 
CI" might potentially ignores those changes coming after your comment which are 
problematic. 
   
   so in general, I would suggest the committer who is merging a PR, check the 
CI results before he merges it and leave "Ignore CI" after he confirms the CI 
build failures come from flakes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to