reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364008
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.tools.cli.commands.bookie; + +import com.beust.jcommander.Parameters; +import com.google.common.collect.Lists; +import java.util.List; +import org.apache.bookkeeper.bookie.Journal; +import org.apache.bookkeeper.bookie.LedgerDirsManager; +import org.apache.bookkeeper.bookie.LogMark; +import org.apache.bookkeeper.conf.ServerConfiguration; +import org.apache.bookkeeper.tools.cli.helpers.BookieCommand; +import org.apache.bookkeeper.util.DiskChecker; + +/** + * A bookie command to print the last log marker. + */ +@Parameters(commandDescription = "Print last log marker") +public class LastMarkCommand extends BookieCommand { Review comment: cguttapalem@cguttapale-ltm1:~/Workspace/Community/bookkeeper/bin$ ./bookkeeper-cli Usage: bookie-shell [options] [command] [command options] Options: -c, --conf Bookie Configuration File -h, --help Show this help message Default: false Commands: bookie Commands on operating a single bookie Usage: bookie [options] client Commands that interact with a cluster Usage: client [options] cluster Commands that operate a cluster Usage: cluster [options] metadata Commands that interact with metadata storage Usage: metadata [options] -------------------------------------------------------------------- 1) it is definitely not obvious for the first time users 2) In the following line what does "bookie-shell" refer to? because when I tried "./bookkeeper-cli bookie-shell bookie" it doesn't output just "bookie" command usage. Usage: bookie-shell [options] [command] [command options] 3) in the existing shell we have couple of options for commands - ledgeridformat and entryformat. It seems it is missing in the new CLI 4) I'm concerned about flexibility with jcommander framework for commands with complicated options like 'readlog' command - (readlog [-msg] <entry_log_id | entry_log_file_name> [-ledgerid <ledgerid> [-entryid <entryid>]] [-startpos <startEntryLogBytePos> [-endpos <endEntryLogBytePos>]]) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
