jvrao commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r168567864
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
##########
@@ -93,6 +95,7 @@ static PendingAddOp create(LedgerHandle lh, ByteBuf payload,
AddCallback cb, Obj
op.callbackTriggered = false;
op.hasRun = false;
op.requestTimeNanos = Long.MAX_VALUE;
+ op.allowFastFailOnBlockedWrite = false;
Review comment:
My request is to shift the focus to the channel. All we need to know how
many requests/data-size channel can accept once it turned non-writable.
(another tunable)? Reset this counter as soon as channel turns writable. If the
caller waited or not should not influence the channel to submit the request of
fail-fast. That avoids sending flag down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
