sijie commented on a change in pull request #1172: Use 
BookieServer#getLocalAddress as the identifier in the test
URL: https://github.com/apache/bookkeeper/pull/1172#discussion_r169215261
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
 ##########
 @@ -426,12 +421,7 @@ public void testSyncBookieRecoveryToSpecificBookie() 
throws Exception {
         writeEntriestoLedgers(numMsgs, 10, lhs);
 
         // Call the sync recover bookie method.
-        BookieSocketAddress bookieSrc = new 
BookieSocketAddress(InetAddress.getLocalHost().getHostAddress(),
-          initialPort);
-        BookieSocketAddress bookieDest = new 
BookieSocketAddress(InetAddress.getLocalHost().getHostAddress(),
-          newBookiePort);
-        LOG.info("Now recover the data on the killed bookie (" + bookieSrc + 
") and replicate it to the new one ("
-          + bookieDest + ")");
+        LOG.info("Now recover the data on the killed bookie (" + bookieSrc + 
") and replicate it to other bookies");
 
 Review comment:
   yes. because `bookieDest` is actually not used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to