ivankelly commented on a change in pull request #898: Bookies should prioritize 
recovery reads/writes
URL: https://github.com/apache/bookkeeper/pull/898#discussion_r169888117
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
 ##########
 @@ -154,9 +162,15 @@ public BookieRequestProcessor(ServerConfiguration 
serverCfg, Bookie bookie,
                 statsLogger);
         this.longPollThreadPool = createExecutor(
                 this.serverCfg.getNumLongPollWorkerThreads(),
-                "BookieLongPollThread",
-                OrderedScheduler.NO_TASK_LIMIT,
-                statsLogger);
+                "BookieLongPollThread-" + serverCfg.getBookiePort(),
+                OrderedScheduler.NO_TASK_LIMIT, statsLogger);
+        this.highPriorityThreadPool = Executors.newCachedThreadPool(
 
 Review comment:
   no idea. I just reused what was there for fencedThreadPool. probably 
something about newCachedThreadPool being harder to fail, because of 
unboundedness, but this introduces problems of it's own. Will change to 
something bounded.
   
   On a side note, with these thread pools, the architecture is starting to 
look more like something which could benefit from an actor architecture using 
something like lmax disruptor. Way in the future though, if at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to