sijie commented on a change in pull request #898: Bookies should prioritize 
recovery reads/writes
URL: https://github.com/apache/bookkeeper/pull/898#discussion_r170391056
 
 

 ##########
 File path: bookkeeper-proto/src/main/proto/BookkeeperProtocol.proto
 ##########
 @@ -101,6 +101,7 @@ message ReadRequest {
     optional int64 previousLAC = 4;
     // Used as a timeout (in milliseconds) for the long polling request
     optional int64 timeOut = 5;
+    optional uint32 priority = 6 [default = 0];
 
 Review comment:
   Can you make priority as part of PacketHeader? so this would be available to 
all type of requests.
   
   As what I kind see here, it can be reused by `GetBookieInfoRequest`, 
`WriteLacRequest` and `ReadLacRequest` potentially. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to