ivankelly commented on a change in pull request #832: Issue 620: Close the
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170901464
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -703,7 +716,7 @@ void stop() {
* Entry Log File Id
*/
protected boolean removeEntryLog(long entryLogId) {
- removeFromChannelsAndClose(entryLogId);
+ fileChannelBackingCache.removeFromChannelsAndClose(entryLogId);
Review comment:
What about the entries still in the caches? I would suggest you get rid of
```removeFromChannelsAndClose``` completely, and invalidate the entry from all
the caches. You could also do nothing, as the cache would release their
refcount eventually, but better to help it along a little.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
