merlimat commented on a change in pull request #1218: Support LacPiggyback,
LongPoll and ExplicitLac in db ledger storage
URL: https://github.com/apache/bookkeeper/pull/1218#discussion_r171345374
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
##########
@@ -712,23 +874,38 @@ public EntryLogger getEntryLogger() {
@Override
public long getLastAddConfirmed(long ledgerId) throws IOException {
- throw new UnsupportedOperationException();
+ TransientLedgerInfo ledgerInfo =
transientLedgerInfoCache.getIfPresent(ledgerId);
+ Long lac = null != ledgerInfo ? ledgerInfo.getLastAddConfirmed() :
null;
+ if (null == lac) {
+ ByteBuf bb = getEntry(ledgerId, BookieProtocol.LAST_ADD_CONFIRMED);
+ bb.skipBytes(2 * Long.BYTES); // skip ledger id and entry id
+ lac = bb.readLong();
Review comment:
`bb` should be released at this point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
