sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369711668 > Synchronous communication makes it hard for people to participant. This is why ASF encourages that all discussion happens on the mailing lists [1][2]. > Meetings are the problem here. I disagree with that. Meetings are sometimes better than discussion on the list. We just need to make sure us doing better job on summary and keeping the records onwards. The community has been moving much faster because of meetings which provide more effective ways on communication and discussions. > This is not the case. ?If it didn?t happen on-list, it didn?t happen.?[2]. The community was inactive until recently. Most of the discussions were happening between Twitter, Yahoo and Salesforce through direct meetings, where the meetings were not even public to other people to attend (where the meetings were evolved into the community meetings now). We probably did badly at old days, but that's how we moved the community forward and iterate the community into its current form. It is much better than before. We are following a better apache process on changes happen in bookkeeper. The discussions done before probably didn't follow apache way very well. But it doesn't mean they don't exist. That's why I suggested respecting to the efforts that people have done in the past. The community is still small, the people are still the same people who were involved in the discussions. It makes on sense pointing ASF policies around to rule out those discussions made before we formed a better community process. We all know we need to move forward with a better process. So I would hope us stop any comments like this. It is not helpful at all. Let's focus on technical discussions and let the community decide what is the approach we should take here, take it and move forward. ------------- Technical parts > sub-task5 is at wrong level. > Another option, which could be less work given what you have already, is to duplicate the classes that you are modifying, and making the changes you need there. This way you don't need to touch SortedLedgerStorage, you don't modify code that all other ledger storages use, and the patch should just be whole file additions, and a small modification for enabling users to use the new ledger storage. > It would mean code duplication, but it's easier to factor out duplicate code than to disentangle code. Also, the risk of submission would be zero. A no from me as well on code duplication. still think EntryLogManager is a good approach to take here for multiple entrylogs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
