sijie commented on a change in pull request #1225: Issue #570: getting rid of 
unnecessary synchronization in InterleavedLedgerStorage
URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941537
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
 ##########
 @@ -107,14 +112,18 @@ public void testCorruptEntryLog() throws Exception {
     }
 
     private ByteBuf generateEntry(long ledger, long entry) {
-        byte[] data = ("ledger-" + ledger + "-" + entry).getBytes();
+        byte[] data = generateDataString(ledger, entry).getBytes();
         ByteBuf bb = Unpooled.buffer(8 + 8 + data.length);
         bb.writeLong(ledger);
         bb.writeLong(entry);
         bb.writeBytes(data);
         return bb;
     }
 
+    private String generateDataString(long ledger, long entry) {
+        return new String("ledger-" + ledger + "-" + entry);
 
 Review comment:
   nit: redundant constructor.
   
   ```
   return "ledger-" + ledger + "-" + entry;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to