sijie commented on a change in pull request #832: Issue 620: Close the 
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171945469
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##########
 @@ -1094,25 +1104,40 @@ private Header getHeaderForLogId(long entryLogId) 
throws IOException {
         }
     }
 
-    private BufferedReadChannel getChannelForLogId(long entryLogId) throws 
IOException {
-        BufferedReadChannel fc = getFromChannels(entryLogId);
-        if (fc != null) {
-            return fc;
-        }
-        File file = findFile(entryLogId);
-        // get channel is used to open an existing entry log file
-        // it would be better to open using read mode
-        FileChannel newFc = new RandomAccessFile(file, "r").getChannel();
-        FileChannel oldFc = logid2FileChannel.putIfAbsent(entryLogId, newFc);
-        if (null != oldFc) {
-            newFc.close();
-            newFc = oldFc;
-        }
-        // We set the position of the write buffer of this buffered channel to 
Long.MAX_VALUE
-        // so that there are no overlaps with the write buffer while reading
-        fc = new BufferedReadChannel(newFc, conf.getReadBufferBytes());
-        putInReadChannels(entryLogId, fc);
-        return fc;
+    /**
+     * Add one refCnt for BufferedReadChannel and return it, caller need to 
subtract one refCnt.
+     * @param entryLogId
+     * @return
+     * @throws IOException
+     */
+    private EntryLogBufferedReadChannel getChannelForLogId(long entryLogId) 
throws IOException {
+        try {
+            EntryLogBufferedReadChannel brc;
+            Callable<EntryLogBufferedReadChannel> loader = () -> {
 
 Review comment:
   why do we create loader everytime, this is generating a lot of garbages on 
jvm? I remember the first time I reviewed this, I don't think see loader here...
   
   why can't we use LoadingCache instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to