sijie opened a new pull request #1240: Disable using v2 decoder to decode v3 response if usingV2WireProtocol is enabled and handle unknown op in v2 request decoder URL: https://github.com/apache/bookkeeper/pull/1240 Descriptions of the changes in this PR: *Problem* - response decoder should use whatever protocol that request is using to decode the response. otherwise it is making wrong assumption on response protocol. - v2 request decoder doesn't handle unknown op correctly, which will cause netty double-release bytebuf *Solution* - make sure response decoder respect the protocol that client is using for sending requests - v2 request decoder should throw exceptions when fail to decode unknown request Related issues: #198 > --- > Be sure to do all of the following to help us incorporate your contribution > quickly and easily: > > If this PR is a BookKeeper Proposal (BP): > > - [ ] Make sure the PR title is formatted like: > `<BP-#>: Description of bookkeeper proposal` > `e.g. BP-1: 64 bits ledger is support` > - [ ] Attach the master issue link in the description of this PR. > - [ ] Attach the google doc link if the BP is written in Google Doc. > > Otherwise: > > - [ ] Make sure the PR title is formatted like: > `<Issue #>: Description of pull request` > `e.g. Issue 123: Description ...` > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`. > - [ ] Replace `<Issue #>` in the title with the actual Issue number. > > ---
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
