merlimat commented on issue #1241: NullPointerException in 
PerChannelBookieClient
URL: https://github.com/apache/bookkeeper/issues/1241#issuecomment-371909838
 
 
   Also, I don't understand well the logic here. 
   
   I think teh `setOutstanding()` should be called *before* doing the 
`writeAndFlush()` and not when we did write on the channel is completed. 
   
   The channel might not be writable (thus the future doesn't complete 
immediately) but from our perspective the  operation is still outstanding. 
   
   @kishorekasi Can you confirm?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to