sijie commented on a change in pull request #1236: Issue #570: make changes to
SyncThread/checkpoint logic.
URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r173616847
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -696,14 +698,29 @@ public Bookie(ServerConfiguration conf, StatsLogger
statsLogger)
ledgerStorage =
LedgerStorageFactory.createLedgerStorage(ledgerStorageClass);
syncThread = new SyncThread(conf, getLedgerDirsListener(),
ledgerStorage, checkpointSource);
+ Checkpointer checkpointer;
+ /*
+ * with this change https://github.com/apache/bookkeeper/pull/677,
Review comment:
no, it should be the issue link. because the issue link will contain all
the review comments, but git sha doesn't contain any review comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
