reddycharan commented on a change in pull request #1236: Issue #570: make 
changes to SyncThread/checkpoint logic.
URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r174214945
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java
 ##########
 @@ -108,14 +103,13 @@ public void startCheckpoint(Checkpoint checkpoint) {
         });
     }
 
-    public Future<Void> requestFlush() {
+    public Future requestFlush() {
 
 Review comment:
   1) it is returning void/null.
   2) its return value is not used anywhere.
   3) MockExecutorController doesn't support controlSubmitCallable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to