reddycharan commented on a change in pull request #1236: Issue #570: make 
changes to SyncThread/checkpoint logic.
URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r174220910
 
 

 ##########
 File path: site/_data/config/bk_server.yaml
 ##########
 @@ -43,8 +43,8 @@ groups:
     description: Interval to watch whether bookie is dead or not, in 
milliseconds.
     default: 1000
   - param: flushInterval
-    description: How long the interval to flush ledger index pages to disk, in 
milliseconds. Flushing index files will introduce much random disk I/O. If 
separating journal dir and ledger dirs each on different devices, flushing 
would not affect performance. But if putting journal dir and ledger dirs on 
same device, performance degrade significantly on too frequent flushing. You 
can consider increment flush interval to get better performance, but you need 
to pay more time on bookie server restart after failure.
-    default: 100
+    description: When entryLogPerLedgerEnabled is enabled, checkpoint doesn't 
happens when a new active entrylog is created / previous one is rolled over. 
Instead SyncThread checkpoints periodically with 'flushInterval' delay (in 
milliseconds) in between executions. Checkpoint flushes both ledger entryLogs 
and ledger index pages to disk.  Flushing entrylog and index files will 
introduce much random disk I/O. If separating journal dir and ledger dirs each 
on different devices, flushing would not affect performance. But if putting 
journal dir and ledger dirs on same device, performance degrade significantly 
on too frequent flushing. You can consider increment flush interval to get 
better performance, but you need to pay more time on bookie server restart 
after failure. This config is used only when entryLogPerLedgerEnabled is 
enabled.
+    default: 10000
   - param: allowStorageExpansion
 
 Review comment:
   there is discrepancy in the default value of this config. In 
ServerConfiguration.java it is mentioned as 10000 (10 secs) but in this file it 
is mentioned as 100. So I'm correcting it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to