ivankelly commented on a change in pull request #1256: Issue 1255: Bookie 
should not advance the journal marker before creating the index file
URL: https://github.com/apache/bookkeeper/pull/1256#discussion_r174423929
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java
 ##########
 @@ -60,6 +62,7 @@
 @Slf4j
 class SyncThread implements Checkpointer {
 
+    @Getter(AccessLevel.PACKAGE)
 
 Review comment:
   why even add a getter? it's final

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to