ivankelly commented on a change in pull request #1284: Improve
FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176658955
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java
##########
@@ -92,8 +107,20 @@ private void releaseFileInfo(long ledgerId, CachedFileInfo
fileInfo) {
}
void closeAllWithoutFlushing() throws IOException {
- for (Map.Entry<Long, CachedFileInfo> entry : fileInfos.entrySet()) {
- entry.getValue().close(false);
+ try {
Review comment:
> there is no really matter it is unchecked execution exception or unchecked
io exception.
The difference is the instanceof. With UncheckedIOException:
```
try {
// blah
} catch (UncheckedIOException uio) {
throw uio.getCause(); // returns a IOException
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
