sijie commented on a change in pull request #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#discussion_r176809493
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
##########
@@ -412,28 +413,34 @@ protected void encode(ChannelHandlerContext ctx, Object
msg, List<Object> out) t
usingV3Protocol = true;
}
- @Override
- protected void decode(ChannelHandlerContext ctx, Object msg,
List<Object> out) throws Exception {
+ @Override
Review comment:
the space is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
