eolivelli commented on issue #1286: Implement directly 
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375755481
 
 
   @sijie MessageToMessageEncoder uses reflection and does checks on objects 
types and it does other things not needed so my idea is that we are saving CPU 
cycles.
   
   I will update the description, the change is more a cleanup/refactor and it 
does not address directly the problem, but actually with this refactor the 
problem does not occur anymore.
   
   I agree that describing only part of the evidences is only confusing
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to