ivankelly opened a new pull request #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288 As discussed on the mailing list [1], this patch removes the inconsistency around the naming of the close call on the new handle APIs, by creating sync versions of each async calls, and renaming the async versions to have the suffix "Async". Most of the changes are very mechanical - just a copy of the old method and some small fixups the javadoc. One thing to note is that I've made a copy of the close and closeAsync methods in the WriteHandle interface, so that the ReadHandle and Handle javadoc for these methods do not have to talk about what it means to close/seal a ledger. Another change is that I've removed the SneakyThrows from close, that would have also been needed on the other sync methods. Instead, I pass a exception handler to FutureUtils which generates a BKException. [1] https://lists.apache.org/thread.html/c3784cffb949438510d21e5eac8c0351865c6748c42c380e673a60db@%3Cdev.bookkeeper.apache.org%3E
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services