ivankelly commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177383683
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -292,12 +304,37 @@ public EntryLogger(ServerConfiguration conf,
logId = lastLogId;
}
}
- this.leastUnflushedLogId = logId + 1;
+ this.recentlyCreatedEntryLogsStatus = new RecentEntryLogsStatus(logId
+ 1);
Review comment:
EntryLogManager shouldn't call out to EntryLogger (see comment above). Both
new log creation and flushing act almost entirely on the entrylogmanager. New
log creation needs the listeners, but this is the only place the listeners are
used, so they should be part of the entrylogmanager. EntryLogManager can have a
reference to the RecentEntryLogStatus to update on flush.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
