eolivelli commented on issue #1317: WIP - BP-14 Force Ledger Bookie side 
implementation
URL: https://github.com/apache/bookkeeper/pull/1317#issuecomment-378852184
 
 
   This patch is still WIP, as it lacks important features/fixes:
   - after Bookie restart the LastPersistedEntryId is read from LedgerStorage 
but such recovery must notify the Journal, otherwise at each new forceLedger 
the bookie will not be able to use information on the journal and so it will 
read from LedgerStorage
   - during reviews of early versions of this patch @sijie requested changes on 
SyncCursor in order to have a more efficient implementation (this is still to 
be addressed)
   - I am temporary using AbstractMap.SimpleImmutableEntry to store pairs of 
ledgerId/entryId but it is very inefficient as it uses boxing of Long variables 
and we could use a Recyclable object
   
   But the patch is open for early review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to