sijie commented on a change in pull request #1319: Issue 1316: A bookie with
non-writable dirs should be able to start in readonly mode
URL: https://github.com/apache/bookkeeper/pull/1319#discussion_r179679476
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -416,8 +423,10 @@ File getCurCompactionLogFile() {
protected void initialize() throws IOException {
// Register listener for disk full notifications.
ledgerDirsManager.addLedgerDirsListener(getLedgerDirsListener());
- // create a new log to write
- createNewLog();
+
+ if (ledgerDirsManager.hasWritableLedgerDirs()) {
+ createNewLog();
Review comment:
I know that. Your change involves a refactor which take time to get in, and
probably we can't take it as 4.7.0 release. This change I am doing here is
fixing a bug for 4.7.0 release. I don't think it is needed to couple these two
changes together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
