sijie commented on a change in pull request #1319:  Issue 1316: A bookie with 
non-writable dirs should be able to start in readonly mode
URL: https://github.com/apache/bookkeeper/pull/1319#discussion_r179835269
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
 ##########
 @@ -176,19 +176,10 @@ public boolean hasWritableLedgerDirs() {
             return writableLedgerDirectories;
         }
 
-        // If Force GC is not allowed under no space
-        if (!forceGCAllowWhenNoSpace) {
 
 Review comment:
   1) `forceGCAllowWhenNoSpace` is controlling the gc behavior, it controls 
whether to gc/compaction
   2) this setting is replaced by `minUsableSizeForEntryLogCreation`. because 
not only gc/compaction will create the entry log files on readonly, during 
journal replays it would still need create entry log files. This allows we 
disableForceGC when no space but we can still allow bookie start up in readonly 
mode to replay journals if there is enough space.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to