eolivelli commented on issue #1317: WIP - BP-14 Force Ledger Bookie side 
implementation
URL: https://github.com/apache/bookkeeper/pull/1317#issuecomment-379553214
 
 
   Moving forward with this task, remaining parts:
   - add test case about fencing: forceLedger *should* not work on a fenced 
ledger (fencing is handled in writes, but as new code follows the same scheme 
we should have a test which cover all code branches)
   - add a better implementation of SyncCursor
   
   add all @sijie 's comments in #671 like:
   - https://github.com/apache/bookkeeper/pull/671#issuecomment-340539324 
(rename classes and consider moving SyncCursor to FileInfo)
   - https://github.com/apache/bookkeeper/pull/671#pullrequestreview-72941640 
(use Guava RangeSet)
   
   I have to think about moving SyncCursor to Bookie, because I have to listen 
for 'fsync' on entries already acknowledged and this can be done in Journal and 
not on Bookie (without adding some kind of JounalSyncListener Interface)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to