sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180520230
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyEntryLogger.java
##########
@@ -54,7 +49,7 @@ protected boolean removeEntryLog(long entryLogId) {
}
@Override
- public synchronized long addEntry(long ledger, ByteBuffer entry) throws
IOException {
+ public synchronized long addEntry(Long ledgerId, ByteBuffer entry) throws
IOException {
Review comment:
@reddycharan you can still use long for retreiving from a Long hashmap. why
do you need to change here? in any cases long to Long is a boxing operation, if
single-log manager doesn't need Long, it should be deferred to where it is
really needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
