eolivelli commented on a change in pull request #1317: WIP - BP-14 Force Ledger 
Bookie side implementation
URL: https://github.com/apache/bookkeeper/pull/1317#discussion_r180976504
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java
 ##########
 @@ -103,12 +104,19 @@ void initialize(ServerConfiguration conf,
     long addEntry(ByteBuf entry) throws IOException, BookieException;
 
     /**
-     * Read an entry from storage.
+     * Read an entry from storage. In case of {@link 
BookieProtocol#LAST_ADD_CONFIRMED} we are going to return the
 
 Review comment:
   I am adding this comments because I had to dig into code to understand 
clearly what is the contract of the method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to