sijie opened a new pull request #1338: Fallback to use `getZkServers` and 
`getZkLedgersPath` when resolving from metadata service uri
   Descriptions of the changes in this PR:
   Dlog tests are failing because dlog is using an external zookeeper client, 
where both `zkServers` and `metadataServiceUri`
   are not set on client configuration. It will throw NPE when trying to 
resolve `zkServers` and `zkLedgersRootPath` from metadata service uri.
   Fallback to use deprecated `getZkServers` and `getZkLedgersPath` when 
metadata service uri is null
   Related Issues: #1336 
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   > If this PR is a BookKeeper Proposal (BP):
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   > Otherwise:
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install 
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > ---

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to