reddycharan opened a new issue #1346: incomplete fix for exception handling in 
flushRotatedLogs method and need of ConcurrentList for rotatedLogChannels
   1. Please describe the issue you observed:
   As part of this bug, 
following fix has been made
 but this seems to be an incomplete fix. If there is an exception while closing 
fileChannel (closeFileChannel(channel)) then it is not handled with this fix.
   Also it would be much simpler to use some sort of ConcurrentList for 
rotatedLogChannels, since it would remove the need of guard of synchronization 
on EntryLogger/EntryLogManager instance and it would be much simpler to 
implement function which access / operate on rotatedLogChannels.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to