sijie commented on a change in pull request #1389: Add smoke tests for
LedgerHandleAdv and TailingReads
URL: https://github.com/apache/bookkeeper/pull/1389#discussion_r186033801
##########
File path: pom.xml
##########
@@ -103,6 +103,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<javac.target>1.8</javac.target>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
Review comment:
I am changing the variable *ONLY* in the smoke test module, which is the
module I am testing. I am not touching any other places that have this flag. so
I am not sure if it really needs to be a separated PR, but if you feel strong,
I can do it in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services