reddycharan commented on issue #1380: addBookieAndCheckCovered in RRQuorumCoverageSet doesn't work correctly if AcqQuorumSize is greater than (WriteQuorumSize+1)/2 URL: https://github.com/apache/bookkeeper/issues/1380#issuecomment-386658879 hmm..more comments to this class would have been helpful in understanding the expectation and purpose of RRQuorumCoverageSet. Anyhow I still have following questions 1) *"Sijie: what you expect here is you should have at least one valid response from every quorum"*, if that is the expectation, then it wouldn't work in the following case, where in a writeQuorum if nodesOkay=1 and (nodesNotCovered >= ackQuorumSize). In this case writeQuorum got one okay response but more failure responses than ackQuorumSize. 2) If all the responses are either NoSuchEntryException or NoSuchLedgerExistsException, then nodesOkay=nodesNotCovered=nodesUninitialized=0, and it would return true, is that ok? 3) RoundRobinDistributionSchedule/RRQuorumCoverageSet seems to be a generic class, then why did we bring scenario specific flags/logic (NoSuchEntryException or NoSuchLedgerExistsException) to its implementation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
