eolivelli commented on issue #1395: ISSUE #1390 Ensemble change on delayed write error URL: https://github.com/apache/bookkeeper/pull/1395#issuecomment-386903224 Regarding the test: I did not think that this is not a new class, so okay for keeping your test as it is. Regarding the map: okay for making it a concurrent map, in this case the map will be very small and rarely used so using a ConcurrentHashMap will not have significant impact and it makes things simpler. It can be a simple hashmap btw
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
