reddycharan commented on a change in pull request #1397: Bookies should be from
different racks in a Writequorum.
URL: https://github.com/apache/bookkeeper/pull/1397#discussion_r188794314
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRackawareEnsemblePlacementPolicy.java
##########
@@ -525,17 +526,89 @@ public void testNewEnsembleWithMultipleRacks() throws
Exception {
addrs.add(addr4);
repp.onClusterChanged(addrs, new HashSet<BookieSocketAddress>());
try {
- ArrayList<BookieSocketAddress> ensemble = repp.newEnsemble(3, 2,
2, null, new HashSet<>());
- int numCovered = getNumCoveredWriteQuorums(ensemble, 2);
+ int ensembleSize = 3;
+ int writeQuorumSize = 2;
+ int acqQuorumSize = 2;
+ ArrayList<BookieSocketAddress> ensemble =
repp.newEnsemble(ensembleSize, writeQuorumSize, acqQuorumSize,
+ null, new HashSet<>());
+ int numCovered = getNumCoveredWriteQuorums(ensemble, 2,
numOfAvailableRacks);
assertTrue(numCovered >= 1 && numCovered < 3);
- ArrayList<BookieSocketAddress> ensemble2 = repp.newEnsemble(4, 2,
2, null, new HashSet<>());
- numCovered = getNumCoveredWriteQuorums(ensemble2, 2);
+ ensembleSize = 4;
+ ArrayList<BookieSocketAddress> ensemble2 =
repp.newEnsemble(ensembleSize, writeQuorumSize, acqQuorumSize,
+ null, new HashSet<>());
+ numCovered = getNumCoveredWriteQuorums(ensemble2, 2,
numOfAvailableRacks);
assertTrue(numCovered >= 1 && numCovered < 3);
} catch (BKNotEnoughBookiesException bnebe) {
fail("Should not get not enough bookies exception even there is
only one rack.");
}
}
+ @Test
+ public void testWriteQuorumNumberOfRacks() throws Exception {
Review comment:
added testscenario
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
