jvrao commented on a change in pull request #1410: Issue #1409: Added server
side backpressure (@bug W-3651831@)
URL: https://github.com/apache/bookkeeper/pull/1410#discussion_r189484844
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##########
@@ -665,6 +668,34 @@ public T setNettyMaxFrameSizeBytes(int maxSize) {
return getThis();
}
+ /**
+ * Timeout controlling wait on request send in case of unresponsive
bookie(s)
+ * (i.e. bookie in long GC etc.)
+ *
+ * @return timeout value
+ * negative value disables the feature
+ * 0 to allow request to fail immediately
+ * Default is -1 (disabled)
+ */
+ public long getWaitTimeoutOnBackpressureMillis() {
Review comment:
If it is from the client, how does the client know if the bookie is
slow/dead/hung or something backpressure related? Also, how does this manifest
with rest of the timeouts, say, read/write timeout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
