[GitHub] dlg99 opened a new issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level

[GitBox]

dlg99 opened a new issue #1500: PendingReadOp.logErrorAndReattemptRead logs 
errors with debug level, some of them useful for troubleshooting at info/warn 
level
URL: https://github.com/apache/bookkeeper/issues/1500
 
 
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   ```java
           synchronized void logErrorAndReattemptRead(int bookieIndex, 
BookieSocketAddress host, String errMsg, int rc) {
               if (BKException.Code.OK == firstError
                   || BKException.Code.NoSuchEntryException == firstError
                   || BKException.Code.NoSuchLedgerExistsException == 
firstError) {
                   firstError = rc;
               } else if (BKException.Code.BookieHandleNotAvailableException == 
firstError
                          && BKException.Code.NoSuchEntryException != rc
                          && BKException.Code.NoSuchLedgerExistsException != 
rc) {
                   // if other exception rather than NoSuchEntryException or 
NoSuchLedgerExistsException is
                   // returned we need to update firstError to indicate that it 
might be a valid read but just
                   // failed.
                   firstError = rc;
               }
               if (BKException.Code.NoSuchEntryException == rc
                   || BKException.Code.NoSuchLedgerExistsException == rc) {
                   ++numBookiesMissingEntry;
                   if (LOG.isDebugEnabled()) {
                       LOG.debug("No such entry found on bookie.  L{} E{} 
bookie: {}",
                               lh.ledgerId, eId, host);
                   }
               } else {
     // vvvvv **This would be more helpful for troubleshooting at info/warn log 
level** 
                   if (LOG.isDebugEnabled()) {
                       LOG.debug(errMsg + " while reading L{} E{} from bookie: 
{}",
                               lh.ledgerId, eId, host);
                   }
               }
           }
   
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services