infodog commented on issue #1509: solve  #1476 issue.
URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590
 
 
   @sijie  but in 
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L615
  use `requestComplete` to guarantee request is only close once, while 
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L127
 use `complete` to guarantee ,they are two diff variables. So it's possible 
after the request is closed at the same time entryImpl is recycled, the 
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L127
 code will be executed, and the data maybe ruined.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to