infodog commented on issue #1509: solve  #1476 issue.
URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056
 
 
   @sijie but some times compleRequest() come before request.complte(), such as 
the path on 
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L589,
 this will happen when the response without piggyback data comes before the 
response with data. 
   
   In this case, the request will be closed in completeRequest() by the 
submitCallback() in it, the entryImpl will be recycled. Then the 
request.complete will be called. although this time request.close will not be 
called, but since entryImpl is already recycled , if entryImpl is resued by 
other request, then data will be ruined even the operation is executed in the 
same thread. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to